Remove VCS export feature #9274
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sbidoul
changed the title
sbidoul
force-pushed
the
pip-wheel-must-keep-clone-sbi
branch
from
e5a1284
to
f88343e
Compare
sbidoul
changed the title
Previously, in download mode, it did a vcs export, which did not include vcs information, leading to issues when the build backend required it.
sbidoul
force-pushed
the
pip-wheel-must-keep-clone-sbi
branch
from
2d8701d
to
5214be4
Compare
xavfernandez
approved these changes
Jan 8, 2021
sbidoul
force-pushed
the
pip-wheel-must-keep-clone-sbi
branch
from
5214be4
to
9361faa
Compare
Closed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make
pip downloadof editable requirements do a regular VCS clone/checkout instead of a VCS export.See discussion about alternative approaches in #9338.
Fixes #9273
Fixes #9337
Fixes #9338
Just a failing test for now.