Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle several mypy TODO comments and exceptions #9404

Merged
merged 1 commit into from
Feb 23, 2021
Merged

Handle several mypy TODO comments and exceptions #9404

merged 1 commit into from
Feb 23, 2021

Conversation

jdufresne
Copy link
Contributor

No description provided.

@jdufresne jdufresne mentioned this pull request Dec 30, 2020
Merged
@jdufresne
Copy link
Contributor Author

When this is ready, I'd be happy to break this up into any desired reviewable chunk. Or leave the pieces together.

uranusjr
uranusjr reviewed Jan 1, 2021
View reviewed changes
noxfile.py Outdated Show resolved Hide resolved
@jdufresne
Copy link
Contributor Author

To resolve the distro.*errors, I opened an upstream PR: python-distro/distro#269

@jdufresne jdufresne marked this pull request as ready for review January 4, 2021 15:50
@jdufresne
Copy link
Contributor Author

I think this PR is in a good state where all the easy low hanging fruit has been fixed.

@uranusjr
Copy link
Member

Need to be careful merging this with #9381 since that PR removes pip._internal.utils.typing which this PR uses.

@BrownTruck
Copy link
Contributor

Hello!

I am an automated bot and I have noticed that this pull request is not currently able to be merged. If you are able to either merge the master branch into this pull request or rebase this pull request against master then it will be eligible for code review and hopefully merging!

@BrownTruck BrownTruck added the needs rebase or merge PR has conflicts with current master label Feb 4, 2021
@pypa-bot pypa-bot removed the needs rebase or merge PR has conflicts with current master label Feb 5, 2021
@jdufresne
Copy link
Contributor Author

Rebased

@uranusjr uranusjr added the skip news Does not need a NEWS file entry (eg: trivial changes) label Feb 8, 2021
uranusjr
uranusjr reviewed Feb 8, 2021
View reviewed changes
src/pip/_internal/cli/parser.py Show resolved Hide resolved
src/pip/_internal/network/session.py Outdated Show resolved Hide resolved
@jdufresne
Copy link
Contributor Author

Can we remove mypy: disallow-untyped-defs=False from this file now?

This has been done in commit "fixup! Handle several mypy TODO comments and exceptions". If that looks good to you I can squash the commits.

uranusjr
uranusjr approved these changes Feb 9, 2021
View reviewed changes
Copy link
Member

@uranusjr uranusjr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@jdufresne
Copy link
Contributor Author

Thanks for the review. I've squashed the commits.

@BrownTruck
Copy link
Contributor

Hello!

I am an automated bot and I have noticed that this pull request is not currently able to be merged. If you are able to either merge the master branch into this pull request or rebase this pull request against master then it will be eligible for code review and hopefully merging!

@BrownTruck BrownTruck added the needs rebase or merge PR has conflicts with current master label Feb 18, 2021
@pypa-bot pypa-bot removed the needs rebase or merge PR has conflicts with current master label Feb 19, 2021
@BrownTruck
Copy link
Contributor

Hello!

I am an automated bot and I have noticed that this pull request is not currently able to be merged. If you are able to either merge the master branch into this pull request or rebase this pull request against master then it will be eligible for code review and hopefully merging!

@BrownTruck BrownTruck added the needs rebase or merge PR has conflicts with current master label Feb 19, 2021
@pypa-bot pypa-bot removed the needs rebase or merge PR has conflicts with current master label Feb 20, 2021
@BrownTruck
Copy link
Contributor

Hello!

I am an automated bot and I have noticed that this pull request is not currently able to be merged. If you are able to either merge the master branch into this pull request or rebase this pull request against master then it will be eligible for code review and hopefully merging!

@BrownTruck BrownTruck added the needs rebase or merge PR has conflicts with current master label Feb 21, 2021
@pypa-bot pypa-bot removed the needs rebase or merge PR has conflicts with current master label Feb 21, 2021
@BrownTruck
Copy link
Contributor

Hello!

I am an automated bot and I have noticed that this pull request is not currently able to be merged. If you are able to either merge the master branch into this pull request or rebase this pull request against master then it will be eligible for code review and hopefully merging!

@BrownTruck BrownTruck added the needs rebase or merge PR has conflicts with current master label Feb 22, 2021
@jdufresne
Handle several mypy TODO comments and exceptions
63ea2e8 
Remove mypy exceptions that are straightforward to remove.
@pypa-bot pypa-bot removed the needs rebase or merge PR has conflicts with current master label Feb 23, 2021
@pradyunsg
Copy link
Member

@jdufresne really appreciate you keeping this PR up to date! ^.^

@pradyunsg pradyunsg merged commit 270ddd3 into pypa:master Feb 23, 2021
@jdufresne jdufresne deleted the mypy-fixup branch February 23, 2021 14:11
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 2, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@pradyunsg pradyunsg pradyunsg approved these changes

@uranusjr uranusjr uranusjr approved these changes

Assignees
No one assigned
Labels
skip news Does not need a NEWS file entry (eg: trivial changes)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@jdufresne @uranusjr @BrownTruck @pradyunsg @pypa-bot