commands: debug: Use packaging.version.parse to compare #9464
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Awesome! That was quick 🙂 I'll test it locally (probably tomorrow) as I just fixed up my PR so it doesn't trigger the bug any more. Update: I may not be able to get to this, I upgraded my PC to Python 3.9.1, and everything has stopped working 🙁 (By the way, does anyone know why the tests pin cryptography 2.8? There's no Windows binaries for that version which are compatible with Python 3.9...) |
LOL no. I'd look at the git blame, but my laptop is acting up again so imma deal with that. 🌈 |
|
Yea, I think unpinning is the right thing to do. If you want, I can look into that some time tomorrow. :) |
|
Bumping @pfmoore @pradyunsg |
uranusjr
approved these changes
Jan 22, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #9461