Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better way to run slow linters in CI only #9504

Merged
merged 2 commits into from
Jan 26, 2021

Conversation

sbidoul
Copy link
Member

@sbidoul sbidoul commented Jan 24, 2021

@sbidoul sbidoul added skip news Does not need a NEWS file entry (eg: trivial changes) type: maintenance Related to Development and Maintenance Processes labels Jan 24, 2021
@sbidoul
Copy link
Member Author

sbidoul commented Jan 24, 2021

Sooo... what part of the universe changed so we suddenly have tests failing with No module named easy_install ?

@pradyunsg
Copy link
Member

pypa/setuptools#2544 -- setuptools got rid of easy_install! \o/

@sbidoul
Copy link
Member Author

sbidoul commented Jan 24, 2021

Good. So I guess we can stop testing that we correctly uninstall stuff installed with easy_install ?

@uranusjr
Copy link
Member

I think we still should test against easy_install since there are still all those Ubuntus shipping them. I’ve filed #9509 to fix this.

I was going to ask, does this change mean I can run tox -e lint -- mypy without errors again?

@sbidoul
Copy link
Member Author

sbidoul commented Jan 25, 2021

does this change mean I can run tox -e lint -- mypy without errors again?

I was not aware of that issue, but yes, it does :)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
skip news Does not need a NEWS file entry (eg: trivial changes) type: maintenance Related to Development and Maintenance Processes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants