-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release 21.1 #9828
Release 21.1 #9828
Conversation
@@ -9,6 +9,82 @@ | |||
|
|||
.. towncrier release notes start | |||
|
|||
21.1 (2021-04-24)21.1 (2021-04-24) | |||
================= |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks wrong. :/
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@sbidoul I'm looking into how to fix this w/ towncrier. Seems like this is related to the NEWS handling changes done recently.
https://meet.google.com/fuw-tjbw-xyc is where I'll be sitting if you wanna join. :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hm, I'm going to fix that manually.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sounds good! You'll need to amend the git tag too, if you're doing that.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@pradyunsg I wanted to say hi, but you meet link above is incomplete.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
meet.google.com/fuw-tjbw-xyc is where I'll be sitting if you wanna join. :)
I've left.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@pradyunsg looks like this broken related to that towncrier compat "fix" #9817.
I've found out that towncrier
produces a broken title while towncrier --draft
(that my sphinx extension uses) produces a good one.
This problem has manifested itself in setuptools too: pypa/setuptools#2666. I'll probably be investigating this soonish and track the progress there.
Gah, we have a deprecation that breaks a test :/ |
I'm going to postpone that deprecation to 21.2 as |
One nit-pick: flipping the order of the test fixes vs "bump for release" commit. |
Ok, and I squashed the NEWS.rst fix in to the "bump for release" commit |
Tag 21.1 pushed and green. Now I need permission to push to PyPI. @pradyunsg can you do that (my PyPI user is acsbidoul) |
Heyo! I'd stepped away for lunch. Invite sent! :) |
Same here :)
And upload done! Thanks for helping out. |
refs #9761