-
Notifications
You must be signed in to change notification settings - Fork 145
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Please consider lowercase: pipfile and pipfile.lock #24
Comments
Pipfile (a file) isn't meant to be run as a script. Why would you want to use it in a commandline? |
|
Oh, makes sense. |
Just for the reference, here's what make(1) says about
|
At this point it seems like a pretty common convention. Makefile, Vagrantfile, Dockerfile, and most similarly Gemfile. I think having Pipfile with a capital P makes sense - if you don't like hitting shift, that's more of a personal preference, and there are options to customize your terminal to make tab completion case-insensitive. |
@monkpit please notice the order of preference for |
@dstufft or @kennethreitz - Could one of you say what you think about this? AFAICS, it's going to be pretty easy (and transparent) to support the lower case variant with |
I don't see any reason not to support the lower case variants, we wouldn't combine them, we'd just use the first one we found. |
PEP-518 mentiones pyproject.toml lowercased, some consistency is expected. |
I think having one obvious way to do it is the best path moving forward, e.g. just supporting one filename, but once this library gets more robust, it'll be easier to support other filenames. |
Closing for now — will definitely keep this in mind for the future. |
Is there a good reason why
Pipfile{,.lock}
couldn't be all lowercase? It sucks to have to hit the SHIFT-key when using the commandline, IMHO. At least, please consider accepting bothpipfile
andPipfile
.The text was updated successfully, but these errors were encountered: