Rename Pipfile to Pipfile.toml

[phrohdoh]

There is no benefit in not including the extension (a sense of mystery?).
In fact you will only have things to gain (editor highlighting, etc).

ref: Initially opened here.

[kennethreitz]

we had a long discussion about filenames already, and determined these filenames are best.

[phrohdoh]

@kennethreitz In that case suggesting this be opened here wasn't a good use of anyone's time.

[kennethreitz]

Well, other people may want to comment.

[thekashifmalik]

Wish I had taken part in this discussion when it was going on. Would have really pushed for the very simple pip.toml. Damn docker making everyone adopt the *file convention.

:(

[dstufft]

The *file convention has existed since the 70s, software that can't cope with it is broken.

[thekashifmalik]

Fine I'll bite:

Makefile: makes sense since it's a custom format.
Dockerfile: makes sense since it's a custom format.
Pipfile: silly because it's perfectly valid TOML.

Now we need to tell vim that Pipfile's are TOML.

Where did you guys disqus this BTW? I'll join for future reference.

[akatrevorjay]

I wish I had taken part in this too; I personally really dislike these redundant idioms that thrive among software I see and use every day. It's rather redundant to suffix your files with "file" to be honest; but that I can totally live with pipfile.toml so every engineer in the world that reads it doesn't have to edit their configuration to accommodate it. It also separates the format from the purpose. It's good practice.

It's not even Pythonic requiring a capital letter. :(

[akatrevorjay]

@dstufft It's obviously not about software cope, but human cope.

[janhohenheim]

@kennethreitz Would you consider your stance on this based on the comments in the issue?
Personally, I would like to hear your thoughts on this, as I'm sure you have valid reasons for this decision. However, as it stands, I fail to see any compelling argument for dropping the .toml ending.

[Sajjon]

I too find it very unfortunate that Pipfile (toml), Gemfile, (ruby) Podfile (ruby) does not use the correct file extension, now ALL developers around the world have to tell their texteditor to use the correct syntax highlighting every time every developer open said files. Sure it takes just around one second in Sublime Text (CMD+SHIFT+P SS toml/ruby), but still, whyyyyyy?!

[ghost]

this is more relevant now that pyproject.toml exists,
folks over at rustlang have Cargo.toml and Cargo.lock
consistency ftw

[tony]

vim users:

If you use vim-plug:

Plug 'cespare/vim-toml'  " Support for highlighting toml filetype

if executable('pipenv')
  au BufNewFile,BufRead Pipfile     setf toml
endif

If you already have toml highlighting from a plugin (agnostic of using vim plug) and want Pipfile to be detected as toml:

au BufNewFile,BufRead Pipfile     setf toml

You can also add support for Pipfile.lock:

au BufNewFile,BufRead Pipfile.lock     setf json