Update check-manifest invocation #114
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
check-manifest 0.42 updated `--ignore` handling to be more consistent with MANIFEST.in global-exclude directives. As a result, `tests*` no longer matches files inside a `tests` directory, and you have to use `tests/**` instead. As an extra complication, check-manifest drops Python 2.7 support. Since you still have py27 in this tox.ini, this means you get an older check-manifest 0.41, and you have to tell it to ignore the empty `tests` directory that remains after you exclude all the files in it. For details see the second half of mgedmin/check-manifest#98 I apologize for the inconvenience!
pfmoore
approved these changes
May 4, 2020
Y'all already figured that out, so I left a couple of 👍. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
check-manifest 0.42 updated
--ignorehandling to be more consistent with MANIFEST.inglobal-excludedirectives. As a result,tests*no longer matches files inside atestsdirectory, and you have to usetests/**instead.As an extra complication, check-manifest 0.42 drops Python 2.7 support. Since you still have py27 in this tox.ini, this means you get an older check-manifest 0.41, and you have to tell it to ignore the empty
testsdirectory that remains after you exclude all the files in it.For all the gory details see the second half of mgedmin/check-manifest#98.
I apologize for the inconvenience!