Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Regression after #800 #838

Closed
KOLANICH opened this issue Apr 26, 2023 · 7 comments · Fixed by #841
Closed

Regression after #800 #838

KOLANICH opened this issue Apr 26, 2023 · 7 comments · Fixed by #841

Comments

@KOLANICH
Copy link

KOLANICH commented Apr 26, 2023

After #800 got landed setuptools_scm has started breaking https://github.com/ofek/hatch-vcs (pypa/hatch#795) .

78e7d6b - can build itself, breaks hatch_vcs
bf0e813 - cannot build itself, version.py:15, ImportError: cannot import name '_call_version_scheme' from partially initialized module 'setuptools_scm._entrypoints'
45ad9c8 - cannot build itself, version.py:15, ImportError: cannot import name '_call_version_scheme' from partially initialized module 'setuptools_scm._entrypoints'
8e4e22f - cannot build itself, version.py:15, ImportError: cannot import name '_call_version_scheme' from partially initialized module 'setuptools_scm._entrypoints'
4208223 - cannot build itself, version.py:15, ImportError: cannot import name '_call_version_scheme' from partially initialized module 'setuptools_scm._entrypoints'
fd04e24 - cannot build itself, version.py:15, ImportError: cannot import name '_call_version_scheme' from partially initialized module 'setuptools_scm._entrypoints'
91061f9 - cannot build itself, version.py:18 ImportError: cannot import name '_get_ep' from partially initialized module 'setuptools_scm._entrypoints'
770d5dd - works fine

@RonnyPfannschmidt
Copy link
Contributor

should e resolved on master now

@KOLANICH
Copy link
Author

No, it's not resolved. I test on https://github.com/python/black and use the command python3 -m build -nwx.

@RonnyPfannschmidt
Copy link
Contributor

ok, now i have a local reproducer and found 2 bugs that need extra tests, will implement tommorow

@RonnyPfannschmidt
Copy link
Contributor

@ofek this comes down to hatch-vcs passing in a empty string, i'll make this something that triggers a deprecation warning and will fail in a year or so

RonnyPfannschmidt added a commit to RonnyPfannschmidt/setuptools_scm that referenced this issue Apr 27, 2023
@RonnyPfannschmidt RonnyPfannschmidt linked a pull request Apr 27, 2023 that will close this issue
RonnyPfannschmidt added a commit that referenced this issue Apr 27, 2023
@KOLANICH
Copy link
Author

KOLANICH commented Apr 27, 2023

I confirm, that now it works. Thanks for investigating and fixing it.

@RonnyPfannschmidt
Copy link
Contributor

@KOLANICH btw, it is uncommon to have unreleased versions in use, im curious as to what types of pipeline need/want that (setuptools_scm is currently are not set up for true CI , so thee is a certain risk with that)

@KOLANICH
Copy link
Author

KOLANICH commented Apr 27, 2023

I just prefer using bleeding edge versions of software to

  1. get the latest fixes and features
  2. get aware of the bugs affecting me before they are standardized as "features" compatibility to which is carefully conserved ("we don't hide problems" principle, and IMHO bugs should be fixed, not standardized)
  3. reduce risk of compromise due to relying on the blob in the package registry that noone audits

Some rare breakages are not considered so bad, but instead are viewed as an opportunity to interfere before bugs are cast in stone as "features". Except of them, just installing the most of Python packages from git works pretty fine and I'm making a package manager as a replacement (in fact not quite a replacement, since it relies on some pip machinery and also pip is used to install the packages the ususal way) for pip with the main focus to be used in CI pipelines.

OlenaYefymenko pushed a commit to OlenaYefymenko/setuptools_scm that referenced this issue May 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants