fix issue #103 - reorder version dumping #104
Conversation
|
|
||
|
|
||
| def dump_version(root, version, write_to, template=None): | ||
| assert isinstance(version, string_types) |
There was a problem hiding this comment.
does this detect the new failure?
There was a problem hiding this comment.
the code in dump-version only works with strings, perhaps even this check is not trough enough
| local_scheme=local_scheme) | ||
| return version | ||
|
|
||
| return version_string |
There was a problem hiding this comment.
i like this: much clearer than the previous implementation - i thought of doing something like that in my own PR but refrained to keep things simple...
There was a problem hiding this comment.
i did a more intensive restructure ensuring i never get a string there - the shortcut was an premature optimization, and as such the root of the evil ^^
| def test_dump_version_doesnt_bail_on_value_error(tmpdir): | ||
| write_to = "VERSION" | ||
| version = VERSIONS['exact'] | ||
| version = str(VERSIONS['exact'].tag) |
There was a problem hiding this comment.
not sure what isthis for - would this silence possible unit test failures that could detect the fixed bug?
There was a problem hiding this comment.
exact.tag is a setultools version not a string
|
@anarcat @untitaker unless you have further comments i'm about to release 1.13 |
|
lgtm |
3 participants
No description provided.