use sys.executable instead of 'python' for running regression tests #158
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
good find, thanks for the fix |
|
oh fml @matejcik it seems to have broken the windows tests due to path issues |
|
@matejcik can you take a look at fixing this one, it was my oversight to merge before the windows tests passed, and now i have an obligation to undo the fix because it doesnt work on windows |
|
sorry, don't have a windows env to test it. are there buildbots i can look at or anything? |
|
@matejcik we do have a windows ci for pull requests, https://ci.appveyor.com/project/RonnyPfannschmidt/setuptools-scm-r14ad/build/1.0.126 it will build on pull requests, i am simply guilty of merging too early because your pr looked so good and i completely forgot about windows |
|
oh, it's there hidden under the little X |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
test_regressions.pyis running a python subprocess, but it is using the "python" it finds onPATH, instead of the same executable that is running the test.This could mean that it is testing the wrong thing (if the generic executable is using a different home path) or wrong version of Python (which also means that it creates stray
pycs for the other version).