New git file finder that support symlinks. #247
Conversation
|
it seems this breaks the expectations of some tests which is ok, |
sbidoul
force-pushed
the
git_file_finder-sbi
branch
from
eb33bfb to
3b83b3a
Compare
Make the test compliant with file finder spec (although integration.find_files is not spec compliant yet, because it defaults to '.' with path is empty)
sbidoul
force-pushed
the
git_file_finder-sbi
branch
from
3b83b3a to
c42f7e2
Compare
|
No need to be sorry about anything. The work behing done here is far from easy, with huge expectations from the world. It's green now. |
setuptools_scm/git_file_finder.py
Outdated
| @@ -0,0 +1,67 @@ | |||
| # -*- coding: utf-8 -*- | |||
| # Copyright © 2018 ACSONE SA/NV | |||
| # License LGPLv3 (http://www.gnu.org/licenses/lgpl-3.0-standalone.html) | |||
There was a problem hiding this comment.
i just noted the licence, is it acceptable for you to go to MIT?
There was a problem hiding this comment.
yep, sorry, copy/paste error, I remove that
|
wow, that's quick ^^ |
|
Thanks. Is appveyor running tests on windows? I don't find the link. |
sbidoul
changed the title
|
i need to check to see why its not there |
|
it seems a configuration issue is preventing the ci run, it'll take a bit to investigate |
|
indeed, it got strangely messed up in a token cleanup and appveyor never told details until i recreated the project |
sbidoul
force-pushed
the
git_file_finder-sbi
branch
from
1e7f475 to
5dcae32
Compare
sbidoul
force-pushed
the
git_file_finder-sbi
branch
from
5dcae32 to
b548b50
Compare
|
it seems like windows is giving and giving 😞 |
sbidoul
force-pushed
the
git_file_finder-sbi
branch
from
226e5b8 to
2fbdcff
Compare
|
@RonnyPfannschmidt a bit of trial and error indeed :) I think I nailed it now. Basically it boils down to using normcase everywhere when looking up in the git files list. I chose to preserve case and separators in the finder output. The last two failing tests also fail on master. |
sbidoul
force-pushed
the
git_file_finder-sbi
branch
from
a8ccefb to
2fbdcff
Compare
|
thanks for finalizing the details, i'll take a look at the rest |
sbidoul
force-pushed
the
git_file_finder-sbi
branch
from
4ad0fbe to
2fbdcff
Compare
|
ok, as far as i understand this is merge-able and the tests that dont work in windows are my fault due to developing while windows ci was accidentally off please ack then i'll merge |
|
yes, this PR is ready to merge |
|
great job, thanks for jumping all the hops to iron that one out |
2 participants
Closes #245