Fix 298 - handle no commits for file listing #299
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kentzo
reviewed
Sep 20, 2018
| def _git_ls_files_and_dirs(toplevel): | ||
| # use git archive instead of git ls-file to honor | ||
| # export-ignore git attribute | ||
| cmd = ["git", "archive", "--prefix", toplevel + os.path.sep, "HEAD"] |
There was a problem hiding this comment.
Alternatively output of ls-files can be checked with check-attr.
There was a problem hiding this comment.
would it be wrothwhile to turn this into a pr - and whats the mechanics of that?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #298