Skip to content

fix #381 - clean out env vars from the git hook system #382

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jan 8, 2020
Merged

fix #381 - clean out env vars from the git hook system #382

merged 2 commits into from
Jan 8, 2020

Conversation

RonnyPfannschmidt
Copy link
Contributor

fixes #381

cc @asottile

asottile
asottile approved these changes Dec 13, 2019
View reviewed changes
Copy link
Contributor

@asottile asottile left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good -- thanks for the fix 🎉

@RonnyPfannschmidt
Copy link
Contributor Author

merging while ignoring the broken windows build, that will be fixed separately

@RonnyPfannschmidt RonnyPfannschmidt merged commit 76917be into pypa:master Jan 8, 2020
@asottile asottile mentioned this pull request Mar 19, 2021
Closed
@ltm ltm mentioned this pull request Mar 19, 2021
Open
@RonnyPfannschmidt RonnyPfannschmidt deleted the check-381 branch March 31, 2021 08:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@asottile asottile asottile approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

setuptools-scm does not function when installing as part of a git hook while working inside of a submodule

2 participants

@RonnyPfannschmidt @asottile