Skip to content

fix #625: add tomli to install_requires again #628

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 3, 2021
Merged

fix #625: add tomli to install_requires again #628

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
72c0447
fix #625: add tomli to install_requires again
RonnyPfannschmidt Sep 3, 2021
c530526
prepare for the 6.3.1 release
RonnyPfannschmidt Sep 3, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions CHANGELOG.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,8 @@
6.3.1
=====

* fix #625: restore tomli in install_requires after the regression changes in took it out
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

typo?

Suggested change
* fix #625: restore tomli in install_requires after the regression changes in took it out
* fix #625: restore tomli in install_requires after the regression changes in taking it out

and some users never added it even tho they have pyproject.toml files
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't frequent various Python lists, so I don't understand why I suddenly have to add "tomli" as a dependency in my pyproject.toml...

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wit the change in here you dont, initially one was supposed to use setuptools_scm[toml]

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm using setuptools_scm[toml] everywhere here and it's still failing, not sure why.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(Could be my mistake still somehow, but does show it's tricky to get right)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is transitive, and black is the package breaking. Why it's triggering this at all and not just using a wheel, I don't know.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, okay, so the problem was that tomli was required even when not using toml configuration, so that's what was breaking black. (Again, still don't know why this wasn't getting a wheel and skipping this entirely, but that's why)


6.3.0
=======
Expand Down
1 change: 1 addition & 0 deletions setup.cfg
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,7 @@ packages = find:
install_requires =
packaging>=20.0
setuptools
tomli>=1.0.0 # keep in sync
python_requires = >=3.6
package_dir =
=src
Expand Down