tests: Fix test_git_archhival_from_unfiltered assumptions #757
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This test relied on several things: - editable installation and thereby, '.git_archival.txt' is always accessible. But some Linux distros (e.g. Debian) run tests out of a git tree. - no expansion happens for '.git_archival.txt' (see .gitattributes), i.e. the packaged sources are not produced by git archive. Fixes: pypa#750 Signed-off-by: Stanislav Levin <slev@altlinux.org>
stanislavlevin
force-pushed
the
issue_750
branch
from
f9c7cc4 to
e4d8daa
Compare
|
Thanks! |
RonnyPfannschmidt
referenced
this pull request
Dec 18, 2022
archlinux-github
pushed a commit
to archlinux/svntogit-community
that referenced
this pull request
Dec 19, 2022
pypa/setuptools-scm#757 git-svn-id: file:///srv/repos/svn-community/svn@1361450 9fca08f4-af9d-4005-b8df-a31f2cc04f65
archlinux-github
pushed a commit
to archlinux/svntogit-community
that referenced
this pull request
Dec 19, 2022
pypa/setuptools-scm#757 git-svn-id: file:///srv/repos/svn-community/svn@1361450 9fca08f4-af9d-4005-b8df-a31f2cc04f65
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This test relied on several things:
accessible. But some Linux distros (e.g. Debian) run tests out
of a git tree.
i.e. the packaged sources are not produced by git archive.
Fixes: #750