New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
False positive when checking for inconsistent setup script path on Windows #1519
Comments
@uranusjr Can you provide a minimal reproducing example for this? It seems that the error is being raised from here, based on the error message, but without a failing test or a minimal reproducing example, it's hard to tell how to fix it. |
Of course!
from setuptools import find_packages, setup
setup(
name='project',
version='0.0.0',
package_dir={'': 'src'},
packages=find_packages('src'),
)
|
I did some digging and it seems the most straightforward fix is to call an additional def normalize_path(filename):
"""Normalize a file/dir name for comparison purposes"""
return os.path.normcase(os.path.normpath(os.path.realpath(filename))) This seems reasonable based on the function’s docstring, but I am not sure how accurate it is, and whether the change would have more implications. |
I think based on the file's docstring, it makes sense to add the additional >>> pathlib.Path("path/to/file") == pathlib.Path("path/to/file/")
True |
I can reproduce this. Have been working to move ItsDangerous and MarkupSafe to a |
Oh I missed the PR. Thanks for the pointer. |
Editable installation can be unreliable, as evidenced by pypa/setuptools#1519, which caused Windows tests to fail.
I am not sure what exactly is the cause (I did not have this problem previously, but suddenly sees it when coming back to work on an old project), but it seems to come from a quirk of
realpath()
:The text was updated successfully, but these errors were encountered: