Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Code base modernization #35

Closed
ghost opened this issue Jul 13, 2013 · 6 comments
Closed

Code base modernization #35

ghost opened this issue Jul 13, 2013 · 6 comments
Labels
bug trivial

Comments

@ghost
Copy link

ghost commented Jul 13, 2013

Originally reported by: jaraco (Bitbucket: jaraco, GitHub: jaraco)

Setuptools has been around for quite a while (almost 10 years), and the code base shows some of that age. Since then, the community has established preferred code style guidelines (a la PEP-8) and developed better practices. Additionally, none of the versions of Python supported by Setuptools today were around when Setuptools was started.

I'd like to see the Setuptools codebase updated to conform more closely to the expectations of a modern project.

In particular, let's:

  • Normalize whitespace and imports
  • Use Python 3 constructs (where available on Python 2.4)
  • Use PEP-8 as a guideline for style

This effort is the type of effort that most anyone could do, but I'd like to reserve this effort for a specific individual (or group sprint) who would like to become more familiar with the code base with a relatively innocuous effort.

In order to avoid duplication of effort, if you would like to volunteer for this effort, please assign this ticket to yourself, fork the project, and put together a pull request. Try to make frequent, bite-sized commits with descriptive commit messages for easy review.

Thanks!
@ghost
Copy link
Author

ghost commented Jul 13, 2013

Original comment by agroszer (Bitbucket: agroszer, GitHub: agroszer):

Sidenote: fix the tests first. I need to update winbot.zope.org to use the current sources. Note, https://bitbucket.org/tarek/distribute probably never passed on windows.

@ghost
Copy link
Author

ghost commented Jul 13, 2013

Original comment by jaraco (Bitbucket: jaraco, GitHub: jaraco):

I regularly run tests on Windows, so I believe the test suite is generally up-to-date, with the one exception of two tests I've been ignoring. I filed #37 to capture those failures.

@ghost
Copy link
Author

ghost commented Jul 14, 2013

Original comment by agroszer (Bitbucket: agroszer, GitHub: agroszer):

Anyway, I'll setup winbot as soon as I can get to it.

@ghost
Copy link
Author

ghost commented Jul 15, 2013

Original comment by embray (Bitbucket: embray, GitHub: embray):

I used to be able to run all the Distribute tests on Windows. Not saying that means it'll work for everyone though.

@ghost
Copy link
Author

ghost commented Jul 15, 2013

Original comment by agroszer (Bitbucket: agroszer, GitHub: agroszer):

http://winbot.zope.org/builders

setuptools_master_*

@ghost
Copy link
Author

ghost commented Aug 25, 2013

Original comment by jaraco (Bitbucket: jaraco, GitHub: jaraco):

There haven't been any takers on this task, so I'm closing as won't fix. The code will be modernized piecemeal as time permits.

@ghost ghost closed this as completed Mar 29, 2016
@ghost ghost mentioned this issue Mar 29, 2016
Closed
jaraco pushed a commit that referenced this issue Jan 16, 2021
@webknjaz @jaraco
Use license_files instead of license_file in meta (#35)
a9b3f68 
Singular `license_file` is deprecated since wheel v0.32.0.

Refs:
* https://wheel.readthedocs.io/en/stable/news.html
* https://wheel.readthedocs.io/en/stable/user_guide.html#including-license-files-in-the-generated-wheel-file
jaraco added a commit that referenced this issue Jan 16, 2021
@webknjaz @jaraco
Use extend-ignore in flake8 config (#33)
77fbe1d 
* Use `extend-ignore` in flake8 config

This option allows to add extra ignored rules to the default list
instead of replacing it.

The default exclusions are: E121, E123, E126, E226, E24, E704,
W503 and W504.

Fixes #28.

Refs:
* https://github.com/pypa/setuptools/pull/2486/files#r541943356
* https://flake8.pycqa.org/en/latest/user/options.html#cmdoption-flake8-extend-ignore
*
https://flake8.pycqa.org/en/latest/user/options.html#cmdoption-flake8-ignore

* Enable complexity limit. Fixes jaraco/skeleton#34.

* Replace pep517.build with build (#37)

* Replace pep517.build with build

Resolves #30

* Prefer simple usage

Co-authored-by: Jason R. Coombs <jaraco@jaraco.com>

* Use license_files instead of license_file in meta (#35)

Singular `license_file` is deprecated since wheel v0.32.0.

Refs:
* https://wheel.readthedocs.io/en/stable/news.html
* https://wheel.readthedocs.io/en/stable/user_guide.html#including-license-files-in-the-generated-wheel-file

Co-authored-by: Jason R. Coombs <jaraco@jaraco.com>
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug trivial
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
0 participants