Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
fix for extra names containing '-' #732
Thanks for this and especially thanks for the test.
This change feels like it's shifting the spec for what is a valid extra name. A change like this probably should be reviewed by a larger audience. Has this been discussed elsewhere? Is there a reason that this shift is the obvious best choice?
Also, if/when we decide to move forward with this, would you include a CHANGES.rst entry describing for users the effect of the change?
I'm a bit at a loss here - this looks to me like a pure bugfix:
Both items are required by pep508 and pep 426 (even though it's deferred). A good "in the wild" can be found at https://bitbucket.org/pypa/wheel/src/cf4e2d98ecb1f168c50a6de496959b4a10c6b122/setup.py?fileviewer=file-view-default .
Oh, great. That PEP provides an excellent authoritative reference to indicate from whence the change is derived.
I see how from one perspective this feels like a bugfix, but from another perspective, the previous, established implementation seems to think that it will always normalize by replacing certain characters with underscores.
I wonder if accompanying this change if check_extras should be updated to restrict extra names to match the PEP requirements.
Still, if you want to leave that for others to address later, that's fine. Just add a CHANGES.txt entry for this change, referencing the PEP, and we're good.
As you correctly observed
To move forward can you please assist me in figuring out what is the correct behavior of looking up extras as pep426 states that :
while pep508 defines the extras as:
But makes not statement about how extras are looked up (AFAIK).