Avoid md5 codepaths in FIPS mode #367
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #367 +/- ##
==========================================
- Coverage 73.66% 73.29% -0.38%
==========================================
Files 13 13
Lines 638 644 +6
Branches 97 99 +2
==========================================
+ Hits 470 472 +2
- Misses 142 144 +2
- Partials 26 28 +2
Continue to review full report at Codecov.
|
sigmavirus24
added a commit
that referenced
this pull request
May 18, 2018
After reviewing #367 I realized that this code could be more easily tested if it was broken out from the PackageFile object. Since it was such a tiny refactor, I went ahead, refactored it and added the necessary tests to ensure this just works.
sigmavirus24
added a commit
that referenced
this pull request
May 18, 2018
After reviewing #367 I realized that this code could be more easily tested if it was broken out from the PackageFile object. Since it was such a tiny refactor, I went ahead, refactored it and added the necessary tests to ensure this just works.
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.