Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid md5 codepaths in FIPS mode #367

Merged
merged 1 commit into from May 18, 2018

Conversation

Projects
None yet
2 participants
@dralley
Copy link
Contributor

commented May 18, 2018

No description provided.

@codecov

This comment has been minimized.

Copy link

commented May 18, 2018

Codecov Report

Merging #367 into master will decrease coverage by 0.37%.
The diff coverage is 55.55%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #367      +/-   ##
==========================================
- Coverage   73.66%   73.29%   -0.38%     
==========================================
  Files          13       13              
  Lines         638      644       +6     
  Branches       97       99       +2     
==========================================
+ Hits          470      472       +2     
- Misses        142      144       +2     
- Partials       26       28       +2
Impacted Files Coverage Δ
twine/package.py 81.17% <55.55%> (-3.64%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f2695b0...c9ab7d9. Read the comment docs.

@sigmavirus24 sigmavirus24 merged commit 75d3cd8 into pypa:master May 18, 2018

1 of 3 checks passed

codecov/patch 55.55% of diff hit (target 73.66%)
Details
codecov/project 73.29% (-0.38%) compared to f2695b0
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@dralley dralley deleted the dralley:fips branch May 18, 2018

sigmavirus24 added a commit that referenced this pull request May 18, 2018

Refactor hash generation for testability
After reviewing #367 I realized that this code could be more easily
tested if it was broken out from the PackageFile object. Since it was
such a tiny refactor, I went ahead, refactored it and added the
necessary tests to ensure this just works.

sigmavirus24 added a commit that referenced this pull request May 18, 2018

Refactor hash generation for testability
After reviewing #367 I realized that this code could be more easily
tested if it was broken out from the PackageFile object. Since it was
such a tiny refactor, I went ahead, refactored it and added the
necessary tests to ensure this just works.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.