Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace the remaining uses of pkg_resources with packaging and importlib_metadata. #736

Merged
merged 19 commits into from Mar 2, 2021

Conversation

@jaraco
Copy link
Member

@jaraco jaraco commented Feb 27, 2021

No description provided.

@jaraco
Copy link
Member Author

@jaraco jaraco commented Feb 27, 2021

Type checks are still failing even after excluding 'packaging' similar to the others. grr.

Loading

jaraco added 2 commits Feb 27, 2021
Suppress the import failure as the mypy config doesn't seem to be adequate. Why?
twine/cli.py Show resolved Hide resolved
Loading
Copy link
Contributor

@bhrutledge bhrutledge left a comment

Thanks for doing this! It's been on my list. Just a couple thoughts on managing types.

Loading

twine/package.py Outdated Show resolved Hide resolved
Loading
setup.cfg Outdated Show resolved Hide resolved
Loading
twine/cli.py Show resolved Hide resolved
Loading
@jaraco jaraco merged commit 0bd26af into master Mar 2, 2021
42 checks passed
Loading
@jaraco jaraco deleted the feature/bye-bye-pkg_resources branch Mar 2, 2021
@mdreizin
Copy link

@mdreizin mdreizin commented Mar 9, 2021

Could you please tag the commit to trigger publishing?

Loading

@bhrutledge
Copy link
Contributor

@bhrutledge bhrutledge commented Mar 12, 2021

@mdreizin Thanks for the nudge. I'm hoping do that within the next week.

Loading

@mdreizin
Copy link

@mdreizin mdreizin commented Mar 12, 2021

Just want to say that fix works fine for me. Thanks a lot for refactoring!

Loading

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants