Replace the remaining uses of pkg_resources with packaging and importlib_metadata. #736
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ptools and pkg_resources.
…s, no longer required.
|
Type checks are still failing even after excluding 'packaging' similar to the others. grr. |
Suppress the import failure as the mypy config doesn't seem to be adequate. Why?
Now the error isn't present, apparently. Let's get some syrup for these waffles.
Suppress typecheck failures in importlib_metadata.
bhrutledge
reviewed
Feb 28, 2021
Add a comment indicating which codes to ignore.
sigmavirus24
reviewed
Mar 1, 2021
bhrutledge
reviewed
Mar 2, 2021
bhrutledge
approved these changes
Mar 2, 2021
|
Could you please tag the commit to trigger publishing? |
|
@mdreizin Thanks for the nudge. I'm hoping do that within the next week. |
|
Just want to say that fix works fine for me. Thanks a lot for refactoring! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.