Legacy: Use sysconfig.get_default_scheme() where available #2109
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sysconfig._get_default_scheme() is gone on Python 3.10
hroncok
force-pushed
the
get_default_scheme
branch
from
be49a69 to
01b5a82
Compare
|
The bot is changing irrelevant things here :/ |
gaborbernat
requested changes
May 5, 2021
|
Do you want me to add a style commit first, or to disable the pre-commit CI on the legacy branch? |
|
Definitely don't disable the style check. We need to understand why it's triggered here and not on the master (or other) branches. PS. A wait I see it's the legacy branch. Never mind then. |
|
It's ok to disable pre-commit here. |
hroncok
force-pushed
the
get_default_scheme
branch
from
a08d660 to
13f0948
Compare
hroncok
force-pushed
the
get_default_scheme
branch
from
13f0948 to
2ac7819
Compare
|
Thanks. |
pallxk
added a commit
to pallxk/azure-cli
that referenced
this pull request
Dec 13, 2021
Merged
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
sysconfig._get_default_scheme() is gone on Python 3.10
(We support Fedora 32 for another 3 weeks and we still have legacy virtualenv there. I will patch this in, but I wanted to share it. Not tested yet.)