Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bdist_wheel should start by cleaning up its build directory #147

Open
agronholm opened this Issue Aug 21, 2015 · 5 comments

Comments

Projects
None yet
1 participant
@agronholm
Copy link
Contributor

agronholm commented Aug 21, 2015

Originally reported by: Xavier Fernandez (Bitbucket: xavfernandez, GitHub: xavfernandez)


bdist_wheel does not clean up its build directory making it easy to include obsolete/unwanted files.

On python 2.7, if you run python setup.py bdist_wheel once, add a file in build/lib.linux-x86_64-2.7 and rerun python setup.py bdist_wheel you'll have the file in your wheel.
I had this issue with https://github.com/Polyconseil/getconf but it concerns all packages, you can easily reproduce with the wheel package.

It can be quite unsettling, since it bypasses, all MANIFEST or find_packages rules...

It would seem cleaner and safer to simply start from a fresh directory and delete it afterwards.


@agronholm

This comment has been minimized.

Copy link
Contributor Author

agronholm commented Sep 24, 2015

Original comment by Daniel Greenfeld (Bitbucket: pydanny, GitHub: pydanny):


Had the same problem at BradWhittington/django-mailgun#28.

@agronholm

This comment has been minimized.

Copy link
Contributor Author

agronholm commented Apr 27, 2016

Original comment by Michael Merickel (Bitbucket: mmerickel, GitHub: mmerickel):


Same problem here Pylons/pyramid#2525

Used a stale build folder and had no idea that bdist_wheel would ignore setuptools-git. Honestly the best approach would be to just take the sdist and convert to a wheel, since the sdist does what I want.

@agronholm

This comment has been minimized.

Copy link
Contributor Author

agronholm commented Jun 14, 2017

Original comment by feluxe (Bitbucket: le0m, GitHub: le0m):


bdist_wheel does not clean up its build directory making it easy to include obsolete/unwanted files.

I have the same issue. It's very annoying, because you usually notice the obsolete modules/packages after publishing. So you have to bump version num again, re-build, re-publish, etc...

@agronholm

This comment has been minimized.

Copy link
Contributor Author

agronholm commented Jun 15, 2017

Original comment by JonathonReinhart (Bitbucket: JonathonReinhart, GitHub: JonathonReinhart):


Do you guys think this issue is the cause of my problem where bdist_wheel and sdist bdist_wheel are different? JonathonReinhart/staticx#22 (comment)

@agronholm

This comment has been minimized.

Copy link
Contributor Author

agronholm commented Jun 15, 2017

Original comment by JonathonReinhart (Bitbucket: JonathonReinhart, GitHub: JonathonReinhart):


I've opened this issue with setuptools (1064) for my problem (which may be related to this one).

@agronholm agronholm added this to the 1.0.0 milestone Oct 29, 2017

twm added a commit to twm/yarrharr that referenced this issue Apr 1, 2018

twm added a commit to twm/yarrharr that referenced this issue Apr 1, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.