Add a few additional common patterns for legal and attribution files #251
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tests/test_bdist_wheel.py
Outdated
| @@ -14,7 +14,8 @@ | |||
| 'dummy_dist-1.0.dist-info/RECORD' | |||
| } | |||
| DEFAULT_LICENSE_FILES = { | |||
| 'LICENSE', 'LICENSE.txt', 'LICENCE', 'LICENSE.txt', 'COPYING', 'NOTICE' | |||
| ('LICENSE', 'LICENSE.txt', 'LICENCE', 'LICENSE.txt', 'COPYING', | |||
| 'COPYTING.md', 'NOTICE', 'NOTICE.rst', 'AUTHORS', 'AUTHORS.txt') | |||
| } | |||
There was a problem hiding this comment.
You just changed the declaration from a set of strings to a set containing only one tuple of strings.
There was a problem hiding this comment.
Sorry, stupid mistake; thanks for the catch. The other place I changed it was an implicit tuple, and I didn't parse the braces properly at first glance so I didn't see it was already a set. Fixed.
CAM-Gerlach
force-pushed
the
refine-license-globs
branch
from
9c767d8
to
1f2df68
Compare
CAM-Gerlach
force-pushed
the
refine-license-globs
branch
from
1f2df68
to
2503bed
Compare
|
Thanks! |
|
Thanks @agronholm ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a minor refinement to the default license/legal-related globs included in #138 , adding extension support for COPYING and NOTICE as well (since the former is often encountered with extensions, e.g.
.txt,.md,.rst; and the Apache license allows.txtas well as an extension), and also adds AUTHORS* as licenses have varying attribution requirements and they are sometimes included by reference in the licenses themselves as well. It also adds them in the docs (sorting the list alphabetically there) and adds some additional test filenames to cover these cases with varied extensions in the tests.