fix handling of extras #252
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please rebase this against master and I will merge. |
Ensure extras are properly canonicalized, so corresponding `Provides-Dist` markers will match with the list of extras returned by pkg_resources.
benoit-pierre
force-pushed
the
fix_extras_handling
branch
from
3202415
to
ebe0cf1
Compare
|
Done. |
Codecov Report
@@ Coverage Diff @@
## master #252 +/- ##
==========================================
+ Coverage 59.41% 59.56% +0.14%
==========================================
Files 12 12
Lines 818 821 +3
==========================================
+ Hits 486 489 +3
Misses 332 332
Continue to review full report at Codecov.
|
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ensure extras are properly canonicalized, so corresponding
Provides-Distmarkers will match with the list of extras returned by pkg_resources. See pypa/pip#4617.