Fix typos #562
Merged
Fix typos #562
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mwtoews
commented
Dec 12, 2024
| self.observation_data.weight = new_weights | ||
|
|
||
| def calculate_pertubations(self): | ||
| def calculate_perturbations(self): |
There was a problem hiding this comment.
This change will raise AttributeError if anyone tries to call calculate_pertubations(). If this is an issue, I can re-add the former method with a depreciation warning.
mwtoews
commented
Dec 12, 2024
| """ | ||
| self.build_increments() | ||
| self.parameter_data.loc[:, "pertubation"] = ( | ||
| self.parameter_data.loc[:, "perturbation"] = ( |
There was a problem hiding this comment.
also note this column name change
briochh
approved these changes
Dec 12, 2024
|
Thanks @mwtoews |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a bunch of typos found using codespell. Configuration files are also added to re-check spelling later on. It could also be added as a CI process, if desired.