refactor: update windowed query #15742
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
miketheman
force-pushed
the
miketheman/update-windowed-query
branch
from
2735b34 to
d7a37c7
Compare
The upstream wiki has been updated. This implements the desired changes. See: https://github.com/sqlalchemy/sqlalchemy/wiki/RangeQuery-and-WindowedRangeQuery One notable difference is that the column must be comparable/sortable with a `ge` operator, and the implementation of UUID doesn't appear to work. Use `.name` instead. Previously refactored in pypi#13845 Signed-off-by: Mike Fiedler <miketheman@gmail.com>
miketheman
force-pushed
the
miketheman/update-windowed-query
branch
from
d7a37c7 to
e4bab9f
Compare
ewdurbin
approved these changes
Apr 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The upstream wiki has been updated. This implements the desired changes. See: https://github.com/sqlalchemy/sqlalchemy/wiki/RangeQuery-and-WindowedRangeQuery
One notable difference is that the column must be comparable/sortable with a
geoperator, and the implementation of UUID doesn't appear to work. Use.nameinstead.Previously refactored in #13845