test: add pytest-mock #18008
Closed
test: add pytest-mock #18008
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
See https://pytest-mock.readthedocs.io/ Signed-off-by: Mike Fiedler <miketheman@gmail.com>
Signed-off-by: Mike Fiedler <miketheman@gmail.com>
Most of these are not necessary, but used to demonstrate the utility Signed-off-by: Mike Fiedler <miketheman@gmail.com>
miketheman
commented
Apr 22, 2025
| return account_services.NullDomainStatusService() | ||
| def domain_status_service(mocker): | ||
| service = account_services.NullDomainStatusService() | ||
| mocker.spy(service, "get_domain_status") |
There was a problem hiding this comment.
Note that the fixture sets up the tracking internally, and doesn't change what's returned by calling the fixture, only adds some methods.
If I try to spy on a method that doesn't exist, an AttributeError is raised, so that protects us from spying on things that don't exist, whereas a call_recorder on a created stub offers no such protection.
Signed-off-by: Mike Fiedler <miketheman@gmail.com>
|
Closing, as it helped illustrate the point. The inclusion of the helper is in #18014 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See https://pytest-mock.readthedocs.io/
Example of using
mockerfixture to add amocker.spyfor a single function and asserting its calls in the test.