Skip to content

Add additional unchecked GitLab claims #18650

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 8, 2025
Merged

Add additional unchecked GitLab claims #18650

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
babbc91
Add additional unchecked GitLab claims
di Sep 8, 2025
779bb13
Update comment
di Sep 8, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions tests/unit/oidc/models/test_gitlab.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -218,6 +218,10 @@ def test_gitlab_publisher_all_known_claims(self):
"project_visibility",
"user_access_level",
"groups_direct",
"job_namespace_id",
"job_namespace_path",
"job_project_id",
"job_project_path",
}

def test_gitlab_publisher_computed_properties(self):
Expand Down
6 changes: 5 additions & 1 deletion warehouse/oidc/models/gitlab.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -154,7 +154,7 @@ class GitLabPublisherMixin:

__unchecked_claims__ = {
# We are not currently verifying project_id or namespace_id to protect against
# resurrection attacks: https://github.com/pypi/warehouse/issues/13575
# resurrection attacks: https://github.com/pypi/warehouse/issues/15643
"project_id",
"namespace_id",
"namespace_path",
Expand All @@ -177,6 +177,10 @@ class GitLabPublisherMixin:
"project_visibility",
"user_access_level",
"groups_direct",
"job_namespace_id",
"job_namespace_path",
"job_project_id",
"job_project_path",
}

# Get the most specific publisher from a list of publishers,
Expand Down