oidc/gitlab: Support single-character workflow filenames #18774
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Turbo87
force-pushed
the
gitlab-workflow-paths
branch
from
b28c547 to
7bcd5fd
Compare
di
reviewed
Sep 29, 2025
Turbo87
force-pushed
the
gitlab-workflow-paths
branch
from
a9bc9f3 to
34fb30b
Compare
di
approved these changes
Sep 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm currently working on GitLab support for the Trusted Publishing implementation of crates.io and noticed that the regular expression that PyPI uses does not accept single character workflow filenames like
a.yml.This PR should hopefully fix the problem if CI confirms it... 🤞