Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #67, supersedes #61
Greetings 👋,
I love your package and use it ev.ery.where, thank you so much for it!
Since I'd like to check out the upcoming Composer 2.0 release, this PR aims to add support for it. I tried to be as unobtrusive with my changes as possible, but also thought that this might be an opportunity to add some other updates.
Notable changes
Composer ^2.0
The plugin was pretty much 2.0-ready already 🥳, only the tests needed some adaptions. The Plugin now has empty
deactivate()
anduninstall()
methods, and I wasn't able to figure out what to fill them with 🤷♂️.PHP CS Fixer ^2.16
I had to remove the dev-dependency because PHP CS Fixer is currently limited to
composer/semver: ^1.4
.Once PHP-CS-Fixer/PHP-CS-Fixer#4935 is addressed, it could be added back, but in the meantime, this is resolved on Travis CI with an ad-hoc download of the PHAR, and locally e.g. with a
composer global require friendsofphp/php-cs-fixer
PHPUnit ^7.5
I added
: void
to thesetUp()
andtearDown()
methods to ease the migration path to PHPUnit 8/9.There was a mixture of
$this->assert*
andstatic::assert*
, so I unified all calls to use$this
(just my personal preference 😅)@expectException*
annotations have been deprecated, so I replaced them with$this->expectException*
I hope that the changes meet with your approval, and I'm looking forward to your review! 🌺