Skip to content

Conversation

Qazalbash
Copy link
Contributor

FAILED test/test_distributions.py::test_entropy_samples[Beta-<lambda>-params8] - assert (Array(False, dtype=bool) or Array(False, dtype=bool))
FAILED test/test_distributions.py::test_entropy_samples[BetaProportion-<lambda>-params11] - assert (Array(False, dtype=bool) or Array(False, dtype=bool))

These tests were failing due to a stderr being zero. I have fixed it by taking a very small number if there is a zero.

…t_entropy_samples` to handle zero standard deviation
@Qazalbash
Copy link
Contributor Author

Failing test cases are fixed in #2067.

@fehiepsi
Copy link
Member

fehiepsi commented Sep 5, 2025

Thanks @Qazalbash! Could we merge the fixes or mark the current failing tests by xfail so that we can address them in the other PR?

@Qazalbash
Copy link
Contributor Author

Asking out of curiosity, what's the point of marking them when they are fixed in #2067? Just merge them one after another.

@fehiepsi
Copy link
Member

fehiepsi commented Sep 5, 2025

We cant merge PR with failing checks.

Copy link
Member

@fehiepsi fehiepsi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix, @Qazalbash!

@fehiepsi fehiepsi merged commit 445f548 into pyro-ppl:master Sep 5, 2025
10 checks passed
@Qazalbash Qazalbash deleted the fix-entropy-samples-tests branch September 5, 2025 19:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants