Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add .github/workflows/publish.yml to publish to pypi.org #3326

Merged
merged 1 commit into from
Feb 15, 2024

Conversation

fritzo
Copy link
Member

@fritzo fritzo commented Feb 14, 2024

This aims to automate part of pyro's release process, namely uploading the pyro-ppl package to pypi.

I don't know how to test this script. I've copied it from github docs (which seems to be newer than the starter workflow; see all versions here).

I've also created an org-wide secret PYPI_API_TOKEN. I'm unsure whether there's anything else I need to do to make this secret available to the workflow.

@eb8680
Copy link
Member

eb8680 commented Feb 15, 2024

I don't know how to test this script

I'm not sure if it will run from a branch other than the designated main branch (dev), but I think you can merge this into dev and cut a test release that won't be installed by people who don't explicitly request it by doing the following (possibly redundant) steps:

  1. Including a pre-release suffix in the setup.py semver and commit tag (e.g. 1.8.6-alpha0)
  2. Marking the GitHub test release as a pre-release and as not the latest release
  3. Yanking or deleting the release from PyPI and GitHub after it is published

Copy link
Member

@eb8680 eb8680 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be correct as long as the PyPI API token is valid. Feel free to merge and cut a test release to exercise the workflow, unless there's a way to test it from this branch.

@fritzo fritzo merged commit 800a484 into dev Feb 15, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants