This repository has been archived by the owner on Aug 6, 2023. It is now read-only.
Make sure phar:// includes aren't blocked by suhosin #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
saltybeagle
added a commit
that referenced
this pull request
May 3, 2011
Make sure phar:// includes aren't blocked by suhosin
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I grabbed a copy of pyrus.phar (version 2.0.0a3) today, and when executing it, there was no output at all. After further investigation, it seems that by default suhosin disables including files that use the
phar://stream wrapper. Since there was no output or error messages, it took a while to track down what was going on.I'm not sure whether or not it's appropriate to include this check, since suhosin isn't "part" of PHP, but given that it's enabled by default on debian/ubuntu, I think it's an issue a lot of users may encounter. Perhaps a note in the manual somewhere would be another (better?) solution.