Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Noticed that when I tried to manually add a constant I wasn't getting the appropriate exception. For instance, model1 below works (no manual constant) but model2 throws a singular matrix error (because of the manual constant and automatic constant) instead of the expected "x array cannot contain a constant vector; constant will be added automatically".
It looks like the constant_check function is missing its input of 'x' and to obtain the correct behavior the 'not' should be removed from the if statement as well.
It was suggested that I tag a spreg developer pertaining to this potential bug. @pedrovma @darribas