Accessibility Function - #32
Conversation
| flow = flow.loc[:,['origin_ID', 'destination_ID','distances', 'volume_in_unipartite','dest_masses','results_all=False']] | ||
| flow['acc_uni'] = function(flow_df = flow, all_destinations=False) | ||
|
|
||
| self.assertEqual(flow['results_all=False'].all(), flow['acc_uni'].all()) |
There was a problem hiding this comment.
I don't think this does what you think it does! check what flow['results_all=False'] looks like!
You may want to use something like numpy.testing.assert_allclose or numpy.testing.assert_array_equal, which are designed to compare numpy arrays.
There was a problem hiding this comment.
I think I addressed this correctly. Let me know if not :).
|
Looks good @lenkahas 🎉 I've got some comments/suggestions for you! |
|
@ljwolf, It looks like @lenkahas has addressed your comments (from what I can tell). Is there anything preventing this merge? |
|
I have recently reviewed the function and needed to alter the calculation for the bipartite graph. |
|
I have accidentally closed this. Could this be reopened? |
|
Super, thanks @lenkahas! I think there are still a few minor things above that need to be done before merging. Are you OK if I do these myself? |
This comment was marked as spam.
This comment was marked as spam.
|
This should probably have been merged at approval! should be good to go? |
6 participants
This pull request includes all the work for the GSoC project of including competing destination estimation into SpInt module.
For more information please visit my blog https://lenkahas.com/post/gsoc.html.