Skip to content

BUG: treatment of keys #28

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Apr 1, 2020
Merged

BUG: treatment of keys #28

merged 3 commits into from
Apr 1, 2020

Conversation

aburrell
Copy link
Member

Description

Found a bug in utils.extract where a list of keys was not created correctly.

Also made some style changes and improved the model loading logic.

Type of change

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

This has been run using multiple instruments and time periods lasting from several days to a year.

Test Configuration:

  • Operating system: OS X
  • Version number: 2.7 and 3.7

Checklist:

  • Make sure you are merging into the develop (not master) branch
  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@aburrell
BUG: list of keys
555c492 
Fixed dimension logic by explicitly creating a list of keys.
@aburrell
STY: import order and docstrings
63c1ab3 
Updated docstring to include all routines and fixed import blocks.
@aburrell
ENH: added try/except for model file loading
749beb2 
Added try/except for model file loading to allow model loading routines to fail
informatively using IOError or ValueError, and still allow the rest of the files to load.
@aburrell aburrell added this to the 1.0.0 release milestone Mar 10, 2020
@aburrell aburrell added the bug Something isn't working label Mar 10, 2020
jklenzing
jklenzing reviewed Mar 13, 2020
View reviewed changes
Copy link
Member

@jklenzing jklenzing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good. Question about usage.

rstoneback
rstoneback approved these changes Mar 17, 2020
View reviewed changes
pysatModels/utils/match.py
from os import path
from pandas import (DateOffset, date_range)

from pandas import (DateOffset, date_range)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are tuples of methods part of a style recommendation?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't recall, I normally don't use them.

@aburrell aburrell merged commit 881ecf1 into develop Apr 1, 2020
@aburrell aburrell deleted the more_bugs branch April 1, 2020 21:53
@jklenzing jklenzing mentioned this pull request Apr 1, 2020
Merged
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jklenzing jklenzing jklenzing left review comments

@rstoneback rstoneback rstoneback approved these changes

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
1.0.0 release
Development

Successfully merging this pull request may close these issues.
3 participants
@aburrell @rstoneback @jklenzing