-
Notifications
You must be signed in to change notification settings - Fork 7
BUG/STY: fix GOLD updates #163
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jklenzing
commented
Apr 14, 2023
jklenzing
commented
Apr 14, 2023
jklenzing
commented
Apr 14, 2023
aburrell
reviewed
Apr 17, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are the windows tests expected to fail?
Windows 10 will fail until pysat 3.1.0 is released. |
aburrell
approved these changes
Apr 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Several bugfixes were pushed to develop for GOLD data while #161 was under review. Additionally, some data products were changed to use the cdasws functions for download. 2 of the 3 new products in #161 could use this, but the third was not in the cdasws database.
Updates #161 with latest bugfixes, style. Note that full functionality requires pysat 3.1.0. Basic functionality (loading single days, not multiple days) is maintained for earlier pysat versions, but will likely be re-addressed after pysat 3.1.0 is released.
Type of change
How Has This Been Tested?
Load new gold data.
Test Configuration
Checklist:
develop
(notmain
) branchCHANGELOG.md
, summarizing the changes