Skip to content

Conversation

jklenzing
Copy link
Member

@jklenzing jklenzing commented Apr 14, 2023

Description

Several bugfixes were pushed to develop for GOLD data while #161 was under review. Additionally, some data products were changed to use the cdasws functions for download. 2 of the 3 new products in #161 could use this, but the third was not in the cdasws database.

Updates #161 with latest bugfixes, style. Note that full functionality requires pysat 3.1.0. Basic functionality (loading single days, not multiple days) is maintained for earlier pysat versions, but will likely be re-addressed after pysat 3.1.0 is released.

Type of change

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

Load new gold data.

Test Configuration

  • Operating system: Monterrey
  • Version number: python 3.9.7
  • Any details about your local setup that are relevant

Checklist:

  • Make sure you are merging into the develop (not main) branch
  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • Add a note to CHANGELOG.md, summarizing the changes
  • Update zenodo.json file for new code contributors

@jklenzing jklenzing marked this pull request as ready for review April 14, 2023 19:22
Copy link
Member

@aburrell aburrell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are the windows tests expected to fail?

@jklenzing
Copy link
Member Author

Are the windows tests expected to fail?

Windows 10 will fail until pysat 3.1.0 is released.

@jklenzing jklenzing requested a review from aburrell April 18, 2023 14:02
@jklenzing jklenzing merged commit 7040e79 into develop Apr 18, 2023
@jklenzing jklenzing deleted the inst/gold_pr branch April 18, 2023 14:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants