Skip to content

Conversation

jklenzing
Copy link
Member

Description

Addresses #172

When downloading numerous small files in close proximity to the data servers, sometimes the default code will return an excessive server request error. This adds a brief pause after each download to avoid erroring.

Type of change

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

Running unit tests at locations where this issue arises.

Test Configuration

  • Operating system: Monterrey
  • Version number: python 3.10
  • Physically near the servers

Checklist:

  • Make sure you are merging into the develop (not main) branch
  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • Add a note to CHANGELOG.md, summarizing the changes
  • Update zenodo.json file for new code contributors

@jklenzing jklenzing added this to the 0.0.5 Release milestone May 31, 2023
@jklenzing jklenzing linked an issue May 31, 2023 that may be closed by this pull request
@jklenzing jklenzing marked this pull request as ready for review June 2, 2023 19:35
@jklenzing jklenzing requested a review from JonathonMSmith June 2, 2023 19:35
@jklenzing
Copy link
Member Author

0.2 sec works for me on campus, 0.1 sec is too short.

@jklenzing jklenzing merged commit 37294e5 into develop Jun 5, 2023
@jklenzing jklenzing deleted the bug/172_download branch June 5, 2023 14:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

BUG/TST: use sleep during instrument download tests
2 participants