2023.12.1 documentation changes #52
Conversation
| import sys | ||
| print(sys.version) | ||
| </script> | ||
| <div id="editor"></div> <!-- will eventually contain the Python editor --> |
There was a problem hiding this comment.
will eventually contain the output, not the editor ... the editor is @codemirror matter; where the output land, the target for print statements, is what the target attribute refers to.
There was a problem hiding this comment.
My deep apologies I've just checked the code and you were right ... the target as it was with classic is where the editor should be shown, I feel like we miss an output attribute at this point for where the editor output lands ... this is all new to me, I've messed up my previous comment as I was confused myself.
There was a problem hiding this comment.
NP - I'll revert the change, but I like the output attribute... this what refinement looks like. ;-)
|
A minor typo or misleading comment a part, the rest LGTM 👍 |
DO NOT MERGE UNTIL 2023.12.1 IS RELEASED