100% Hooks Coverage #48
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
antocuni
approved these changes
Sep 26, 2023
WebReflection
force-pushed
the
worker-hooks-lifecycle
branch
from
0ebe236 to
5e8b20a
Compare
WebReflection
force-pushed
the
worker-hooks-lifecycle
branch
from
5e8b20a to
cf25207
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This MR tests that every single documented hook works as expected either with
<script type="custom">or<custom-type>and it fixes a timing issue (regression) on bootstrap introduced byqueueMicrotask.This MR also uses the right hook in workers when
asyncis defined, without falling back automatically./cc @antocuni