Improved js_modules support #74
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This MR allows MicroPython to use
polyscript.js_modules
same way Pyodide supports it already by doing the following:polyscript
andpolyscript.js_modules
to resolve the magic behavior in Pyodide impossible to replicate in MicroPythonThe latter point means that a similar solution can be used to fix pyscript/pyscript#1899 too so that we don't need anymore to pollute the global with another entry as js_modules is and both py and mpy can work seamlessly when it comes to import modules.