Use a better fetch utility #82
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WebReflection
force-pushed
the
better-fetch
branch
from
618eaf2 to
be03f61
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In both polyscript and PyScript we do fetch within try/catch and share utilities from this module in a pretty awkward way.
As I've published a 10 LOC utility that does a way better job and it helps reducing code and verbosity + it allows us to drop those utilities out of the box, this MR would like to adopt that module (which is basically done) and use a better pattern to both simplify our life without removing 100% control over regular or more articulated fetch operations.