Skip to content

Conversation

fpliger
Copy link
Contributor

@fpliger fpliger commented May 15, 2023

Close #9

I'm intentionally using run instead of serve as cmd name because I think it's more user friendly. Happy to be convinced otherwise :)

@fpliger fpliger requested a review from mchilvers May 15, 2023 21:27
@mattkram
Copy link
Collaborator

I agree it's more intuitive 😁. Serve is technically correct, but that's an implementation detail.

mchilvers
mchilvers previously approved these changes May 16, 2023
@codecov-commenter
Copy link

codecov-commenter commented May 16, 2023

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (9ad6714) to head (16c9e76).
Report is 48 commits behind head on main.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff            @@
##              main       #84   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            3         5    +2     
  Lines          240       287   +47     
=========================================
+ Hits           240       287   +47     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@fpliger fpliger merged commit 3bd6a3e into main May 16, 2023
@fpliger fpliger deleted the fpliger/9_add_run_cmd branch May 16, 2023 20:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add pyscript serve subcommand
5 participants