Skip to content

Conversation

FabioRosado
Copy link
Contributor

While looking at the pyscript.net I noticed that when you hover the documentation section, the link doesn't change color:

before

This PR makes the link color to be dark similar to what we do with the icons

Screenshot from 2022-11-02 14-31-01

@alex-martinez
Copy link

alex-martinez commented Nov 8, 2022

This isn't an issue with your PR, but more so some general styling bugs with the .net site.
Wasn't sure where to put this, so I figured as a comment is fine for now. I'm happy to move this conversation somewhere else though.

Screen.Recording.2022-11-08.at.11.18.29.AM.mov

In my recording you'll notice how the "Examples", "Install", and "Documentation" are all slightly different from each other.

Documentation button

  • Enhancement: Rather than the "here" be a link, the whole documentation button should be a link like the "Examples" button is.
  • Bug: When "Documentation" is clicked the bottom left and right border radius is removed. I'm assuming there's js that used to be attached to this button that we could probably remove now.

Install button

  • Enhancement: Use cursor: pointer; this way when a user hovers over the "install" button the pointer cursor appears and the user instinctively knows it's clickable.

@FabioRosado
Copy link
Contributor Author

@alex-martinez Thank you for the comment and glad that it wasn't just me that thought the "docs" should be clickable haha

I'll turn your comment into an issue since it has a few things that should be addressed (I'll probably will push the changes to this PR 😄 )

@tedpatrick tedpatrick merged commit be43ed5 into pyscript:main Nov 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants