py-repl creating duplicate ids

[tedpatrick]

Checklist

• I added a descriptive title
• I searched for other issues and couldn't find a solution or duplication
• I already searched in Google and didn't find any good information or help

What happened?

Within generated DOM elements, the py-repl element creates duplicate ids.

Note: my-repl-2 is denoted 2 times

This is causing this test to fail:
pytest tests/integration/test_zz_examples.py::TestExamples::test_repl

What browsers are you seeing the problem on? (if applicable)

Firefox, Chrome, Safari, Microsoft Edge

Console info

No response

Additional Context

No response

[marimeireles]

On it :)

[antocuni]

@marimeireles
note that PR #881 changed the way IDs are generated, now we use py-internal-X, where X is 0, 1, 2, 3, ...

pyscript/pyscriptjs/src/utils.ts

Lines 41 to 45 in f9194cc

	let _uniqueIdCounter = 0;
	export function ensureUniqueId(el: HTMLElement) {
	if (el.id === "")
	el.id = "py-internal-" + _uniqueIdCounter++;
	}

I think that the bug is still present because I did't change the py-repl logic, but it should make debugging simpler.

Also, I just started another branch to merge base.ts and pyrepl.ts together. So it might make more sense to wait for it to be completed before hunting the bug.

[marimeireles]

The bug isn't there. It was in the way we write elements, was hard to find because I didn't introduce it 😅 (and I thought I did)
But yeah, let's discuss on the PR :)

[marimeireles]

This was fixed by Antonio's PR actually, before I landed mine!
Fixing a different bug, that also happened to fix this behavior.
As an extra step to remove all of these nested ids I have #912 on the way.