Skip to content

Fix #2040 - Polyscript update to provide config dictionary #2041

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 2, 2024
Merged

Fix #2040 - Polyscript update to provide config dictionary #2041

merged 2 commits into from
May 2, 2024

Conversation

WebReflection
Copy link
Contributor

Description

This MR fixes #2040 by providing a config entry in the pyscript module.

/cc @ntoll

Changes

  • updated polyscript to its latest which augments custom scripts on both main and worker with an extra config object literal
  • change the pyscript stdlib to provide a Pythonic version of such config instead
  • test via integration both main and worker scripts get the config and can introspect it

Checklist

  • All tests pass locally
  • I have updated CHANGELOG.md
  • I have created documentation for this(if applicable) - documentation actually on polyscript side

ntoll
ntoll approved these changes May 2, 2024
View reviewed changes
Copy link
Member

@ntoll ntoll left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@WebReflection WebReflection merged commit 5b4e852 into pyscript:main May 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ntoll ntoll ntoll approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@WebReflection @ntoll