Skip to content

add toml support for configs with fast-toml #783

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Sep 23, 2022

Conversation

madhur-tandon
Copy link
Member

@madhur-tandon madhur-tandon commented Sep 21, 2022

@madhur-tandon madhur-tandon added the sprint issue has been pulled into current sprint and is actively being worked on label Sep 21, 2022
@tedpatrick
Copy link
Contributor

In parallel to this PR, we are testing out the https://www.npmjs.com/package/fast-toml implementation with a TOML test suite for suitability on valid and invalid TOML syntax. This library supports TOML 0.5.0 SPEC

Copy link
Contributor

@tedpatrick tedpatrick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have run a small test suite on the TOML library independently with positive results. I move that we proceed and test this more on unstable

@madhur-tandon madhur-tandon merged commit 146264f into pyscript:main Sep 23, 2022
@madhur-tandon madhur-tandon deleted the toml-support branch September 23, 2022 14:41
tedpatrick pushed a commit that referenced this pull request Sep 23, 2022
* add toml support for configs with fast-toml

* fix package-lock.json and pin pyodide to 0.21.2

* use browser version of fast-toml

* disable eslint and add credits

* fix jest issues

* use type attribute for py-config
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
sprint issue has been pulled into current sprint and is actively being worked on
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants