Skip to content

Deprecate pyscript output attribute #981

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Nov 25, 2022

Conversation

FabioRosado
Copy link
Contributor

@FabioRosado FabioRosado commented Nov 24, 2022

This PR deprecates the output attribute in the py-script tag and updates the docs that use it.

Closes: #973

@JeffersGlass
Copy link
Contributor

JeffersGlass commented Nov 24, 2022

Are these changes duplicated in #982 ? From a casual glance it looks like the output deprecation warning and docs are in both.

@FabioRosado
Copy link
Contributor Author

Yes I branched of that other branch since this one would cause a bunch of conflicts haha

Copy link
Contributor

@antocuni antocuni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@FabioRosado FabioRosado merged commit 446c131 into pyscript:main Nov 25, 2022
@FabioRosado FabioRosado deleted the fr/deprecate-output branch November 25, 2022 18:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Getting Started example uses deprecated pyscript.write() method.
3 participants