Skip to content

Conversation

ArtyomVancyan
Copy link
Member

The base option was supposed to override the whole route prefix in the .vtt and .json files. Before the done changes, this did not happen when base was set to an empty string. This PR also includes the tests for keeping the casework stable.

@ArtyomVancyan ArtyomVancyan marked this pull request as ready for review April 18, 2023 19:04
@ArtyomVancyan ArtyomVancyan merged commit be2ff79 into pysnippet:master Apr 18, 2023
@ArtyomVancyan ArtyomVancyan deleted the base-should-override branch April 18, 2023 19:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant